Found by Coverity scan.
Created attachment 304379 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 304379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review Looks good, but the changelog entry is broken! > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:171 > + GtkWidget* inspectorView { nullptr}; Missing a space here.
Comment on attachment 304379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review > Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:102 > + HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 }; This would read better as an enum value than an int.
Created attachment 304496 [details] Patch Correct the patch (after I previously had some problems with webkit-patch).
(In reply to comment #5) > Created attachment 304496 [details] > Patch > > Correct the patch (after I previously had some problems with webkit-patch). Did you want to mark it for review?
Comment on attachment 304496 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304496&action=review r=me > Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103 > + bool ignoreTLSErrors { true }; You might want to make the default value of this to be false to be safer unless someone explicitly says they want to ignore tls errors.
Yeah, please make that false... if it breaks something, let's specify it when constructed instead. I assume that it's already explicitly specified everywhere anyway...?
Sorry guys, but this patch was intended for bug 169598 as this bug is about WebProcess. (In reply to comment #7) > > Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103 > > + bool ignoreTLSErrors { true }; > > You might want to make the default value of this to be false to be safer > unless someone explicitly says they want to ignore tls errors. Yes, this makes sense, thanks!
Created attachment 304762 [details] Patch Finally a patch for the WebProcess..
Comment on attachment 304762 [details] Patch Clearing flags on attachment: 304762 Committed r214104: <http://trac.webkit.org/changeset/214104>
All reviewed patches have been landed. Closing bug.