Bug 169604 – Fix uninitialized public members in WebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tomas Popela]

Found by Coverity scan.

[Tomas Popela]

Created attachment 304379 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 304379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review

Looks good, but the changelog entry is broken!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:171
> +    GtkWidget* inspectorView { nullptr};

Missing a space here.

[David Kilzer (:ddkilzer)]

Comment on attachment 304379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304379&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:102
> +    HTTPCookieAcceptPolicy cookieAcceptPolicy { 0 };

This would read better as an enum value than an int.

[Tomas Popela]

Created attachment 304496 [details]
Patch

Correct the patch (after I previously had some problems with webkit-patch).

[Michael Catanzaro]

(In reply to comment #5)
> Created attachment 304496 [details]
> Patch
> 
> Correct the patch (after I previously had some problems with webkit-patch).

Did you want to mark it for review?

[Alex Christensen]

Comment on attachment 304496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304496&action=review

r=me

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103
> +    bool ignoreTLSErrors { true };

You might want to make the default value of this to be false to be safer unless someone explicitly says they want to ignore tls errors.

[Michael Catanzaro]

Yeah, please make that false... if it breaks something, let's specify it when constructed instead.

I assume that it's already explicitly specified everywhere anyway...?

[Tomas Popela]

Sorry guys, but this patch was intended for bug 169598 as this bug is about WebProcess.

(In reply to comment #7)
> > Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:103
> > +    bool ignoreTLSErrors { true };
> 
> You might want to make the default value of this to be false to be safer
> unless someone explicitly says they want to ignore tls errors.

Yes, this makes sense, thanks!

[Tomas Popela]

Created attachment 304762 [details]
Patch

Finally a patch for the WebProcess..

[Tomas Popela]

Comment on attachment 304762 [details]
Patch

Clearing flags on attachment: 304762

Committed r214104: <http://trac.webkit.org/changeset/214104>

[Tomas Popela]

All reviewed patches have been landed.  Closing bug.