Bug 169603 – Fix uninitialized public members in WebKit2/Platform and WebKit2/PluginProcess

• Status: NEW
• Component: WebKit2

[Tomas Popela]

Found by Coverity scan.

[Tomas Popela]

Created attachment 304377 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 304377 [details]
Patch

Please fix the ChangeLog.

[Alexey Proskuryakov]

Comment on attachment 304377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304377&action=review

> Source/WebKit2/NetworkProcess/NetworkProcessCreationParameters.h:52
> +    bool privateBrowsingEnabled { false };

Can any of the creation parameters actually be uninitialized? Using default values seems as much of a problem as using uninitialised one - perhaps even worse, as UBSan won't catch that.

[Tomas Popela]

Created attachment 304482 [details]
Patch

Correct the patch (after I previously had some problems with webkit-patch).

[Michael Catanzaro]

(In reply to comment #4)
> Can any of the creation parameters actually be uninitialized? Using default
> values seems as much of a problem as using uninitialised one - perhaps even
> worse, as UBSan won't catch that.

Good point. Let's continue the discussion in bug #169598 as those changes should not have been present in this bug.

[Michael Catanzaro]

Ping owners

[Alexey Proskuryakov]

I'm still very much unsure if this is desirable, as it makes it harder to find uninitialized variable issues with UBSan.

[Maciej Stachowiak]

Comment on attachment 304482 [details]
Patch

Seems like a good idea to initialize everything. Unfortunately this patch no longer applies.