Found by Coverity scan.
Created attachment 304375 [details]
Comment on attachment 304375 [details]
Attachment 304375 [details] did not pass mac-wk2-ews (mac-wk2):
Number of test failures exceeded the failure limit.
Created attachment 304382 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 304793 [details]
Correct the patch (after I previously had some problems with webkit-patch).
I'm still very much unsure if this is desirable, as it makes it harder to find uninitialized variable issues with UBSan.
Comment on attachment 304793 [details]
Where these fields found to ever actually be used uninitialized, or is this a "just in case"? I think on the whole it's better to initialize these. Unfortunately, this patch no longer applies, so r- for current version.
I'm really skeptical that leaving variables initially uninitialized at runtime is a good way to "debug" failure to initialize them to some specific value later, given this makes the code significantly less robust.
In this case, the goal was to resolve various warnings from Coverity. WebKit would probably benefit significantly from an effort to get our Coverity results into better shape. Sadly, that requires significant time and effort....