Bug 169589 - Web Inspector: Remove unnecessary assert for Number.percentageString
Summary: Web Inspector: Remove unnecessary assert for Number.percentageString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-13 22:38 PDT by Devin Rousso
Modified: 2017-03-14 10:56 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2017-03-13 22:38 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-03-13 22:38:00 PDT
It is valid to have a fraction greater than 1, as well as for that fraction to be converted to a percentage point.
Comment 1 Devin Rousso 2017-03-13 22:38:49 PDT
Created attachment 304355 [details]
Patch
Comment 2 Matt Baker 2017-03-14 00:59:28 PDT
Comment on attachment 304355 [details]
Patch

r=me. Did this come up? Are we showing values < 0% or > 100%?
Comment 3 WebKit Commit Bot 2017-03-14 01:28:10 PDT
Comment on attachment 304355 [details]
Patch

Clearing flags on attachment: 304355

Committed r213890: <http://trac.webkit.org/changeset/213890>
Comment 4 WebKit Commit Bot 2017-03-14 01:28:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2017-03-14 10:56:44 PDT
Comment on attachment 304355 [details]
Patch

I think the intent here was originally we only ever expected positive numbers. Was there a case where we could get negative numbers?