Bug 169585 – Web Inspector: RTL: add support for Timeline graphs

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This also includes Network and Memory graphs.

[Devin Rousso]

Created attachment 304351 [details]
Patch

[Devin Rousso]

Created attachment 304352 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 304351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304351&action=review

r=me but please consider renames for clarity.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css:61
> +body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive),

Can you add a comment, this is somewhat inscrutable and looks like a bug at first sight.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:-274
> -        this._updateElementPosition(this._element, newBarLeftPosition, "left");

LOL, we even parameterized it already.

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:671
> +        let rightProperty = WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "left" : "right";

These names make me dizzy. Can we clean them up somehow? If this one could appear on the right side but denote the interval start, maybe we should rename the pairs to start/end.

[Devin Rousso]

Comment on attachment 304351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304351&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css:61
>> +body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive),
> 
> Can you add a comment, this is somewhat inscrutable and looks like a bug at first sight.

Sure!  From what I can tell, it seems like this is used to differentiate between the "Request" (inactive) and "Response" (not inactive) sections of a network segment.  This is how we are able to display the two different colors.

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:-274
>> -        this._updateElementPosition(this._element, newBarLeftPosition, "left");
> 
> LOL, we even parameterized it already.

(☞ﾟヮﾟ)☞

>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:671
>> +        let rightProperty = WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "left" : "right";
> 
> These names make me dizzy. Can we clean them up somehow? If this one could appear on the right side but denote the interval start, maybe we should rename the pairs to start/end.

Whoops.  Totally forgot to change these.

[Devin Rousso]

Created attachment 304408 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304408 [details]
Patch

Clearing flags on attachment: 304408

Committed r213928: <http://trac.webkit.org/changeset/213928>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.