Bug 169585 - Web Inspector: RTL: add support for Timeline graphs
Summary: Web Inspector: RTL: add support for Timeline graphs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks: 168287
  Show dependency treegraph
 
Reported: 2017-03-13 21:25 PDT by Devin Rousso
Modified: 2017-03-14 12:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.61 KB, patch)
2017-03-13 22:19 PDT, Devin Rousso
bburg: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (292.80 KB, image/png)
2017-03-13 22:19 PDT, Devin Rousso
no flags Details
Patch (17.04 KB, patch)
2017-03-14 11:54 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-03-13 21:25:21 PDT
This also includes Network and Memory graphs.
Comment 1 Devin Rousso 2017-03-13 22:19:02 PDT
Created attachment 304351 [details]
Patch
Comment 2 Devin Rousso 2017-03-13 22:19:17 PDT
Created attachment 304352 [details]
[Image] After Patch is applied
Comment 3 BJ Burg 2017-03-13 22:28:14 PDT
Comment on attachment 304351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304351&action=review

r=me but please consider renames for clarity.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css:61
> +body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive),

Can you add a comment, this is somewhat inscrutable and looks like a bug at first sight.

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:-274
> -        this._updateElementPosition(this._element, newBarLeftPosition, "left");

LOL, we even parameterized it already.

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:671
> +        let rightProperty = WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "left" : "right";

These names make me dizzy. Can we clean them up somehow? If this one could appear on the right side but denote the interval start, maybe we should rename the pairs to start/end.
Comment 4 Devin Rousso 2017-03-13 22:31:37 PDT
Comment on attachment 304351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304351&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.css:61
>> +body[dir=ltr] .timeline-record-bar.has-inactive-segment > .segment:not(.inactive),
> 
> Can you add a comment, this is somewhat inscrutable and looks like a bug at first sight.

Sure!  From what I can tell, it seems like this is used to differentiate between the "Request" (inactive) and "Response" (not inactive) sections of a network segment.  This is how we are able to display the two different colors.

>> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:-274
>> -        this._updateElementPosition(this._element, newBarLeftPosition, "left");
> 
> LOL, we even parameterized it already.

(☞゚ヮ゚)☞

>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:671
>> +        let rightProperty = WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "left" : "right";
> 
> These names make me dizzy. Can we clean them up somehow? If this one could appear on the right side but denote the interval start, maybe we should rename the pairs to start/end.

Whoops.  Totally forgot to change these.
Comment 5 Devin Rousso 2017-03-14 11:54:45 PDT
Created attachment 304408 [details]
Patch
Comment 6 WebKit Commit Bot 2017-03-14 12:21:00 PDT
Comment on attachment 304408 [details]
Patch

Clearing flags on attachment: 304408

Committed r213928: <http://trac.webkit.org/changeset/213928>
Comment 7 WebKit Commit Bot 2017-03-14 12:21:03 PDT
All reviewed patches have been landed.  Closing bug.