RESOLVED FIXED 169584
Web Inspector: RTL: add support for Memory timeline 
https://bugs.webkit.org/show_bug.cgi?id=169584
Summary Web Inspector: RTL: add support for Memory timeline
Devin Rousso
Reported 2017-03-13 21:24:36 PDT
.
Attachments
Patch (9.48 KB, patch)
2017-03-13 21:49 PDT, Devin Rousso 		bburg: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (338.97 KB, image/png)
2017-03-13 21:49 PDT, Devin Rousso 		no flags
Details
Patch (9.19 KB, patch)
2017-03-14 11:57 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-03-13 21:49:10 PDT
Created attachment 304347 [details] Patch
Devin Rousso
Comment 2 2017-03-13 21:49:51 PDT
Created attachment 304348 [details] [Image] After Patch is applied
Blaze Burg
Comment 3 2017-03-13 22:20:28 PDT
Comment on attachment 304347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304347&action=review r=me. CSS changes look good. I did notice that the size text for each category seems to be backwards compared to the legends. If this uses a localized string, then it should be OK - the localizers can switch 'Highest: %s' to '%s :Highest'. > Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:123 > + markerElement.style.setProperty(WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL ? "right" : "left", `${xScale(memoryPressureEvent.timestamp)}px`); Please extract the property to a local variable so this is easier to read (especially, say, in a search result).
Devin Rousso
Comment 4 2017-03-14 11:57:08 PDT
Created attachment 304410 [details] Patch
WebKit Commit Bot
Comment 5 2017-03-14 14:41:58 PDT
Comment on attachment 304410 [details] Patch Clearing flags on attachment: 304410 Committed r213942: <http://trac.webkit.org/changeset/213942>
WebKit Commit Bot
Comment 6 2017-03-14 14:42:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.