Bug 169583 – Web Inspector: RTL: add support for TimelineOverview sidebar and container layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 304345 [details]
Patch

[Devin Rousso]

Created attachment 304346 [details]
[Image] After Patch is applied

[Blaze Burg]

Comment on attachment 304345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31
> +body[dir=ltr] .timeline-overview > .tree-outline.timelines {

Can this use :matches() ?

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:37
> +body[dir=rtl] .timeline-overview > .tree-outline.timelines {

Ditto

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167
> +    bottom: 0;

Does the ruler still look right in LTR? Or was this property unnecessary?

[Devin Rousso]

Comment on attachment 304345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304345&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31
>> +body[dir=ltr] .timeline-overview > .tree-outline.timelines {
> 
> Can this use :matches() ?

Good catch!

>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167
>> +    bottom: 0;
> 
> Does the ruler still look right in LTR? Or was this property unnecessary?

I did this so that I don't have to add a reset for the other property when only setting one or the other in LTR/RTL (see lines 42 and 46).  This way, I can also merge the rules together to make a single selector.

[Devin Rousso]

Created attachment 304407 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304407 [details]
Patch

Clearing flags on attachment: 304407

Committed r213924: <http://trac.webkit.org/changeset/213924>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.