WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169583
Web Inspector: RTL: add support for TimelineOverview sidebar and container layout
https://bugs.webkit.org/show_bug.cgi?id=169583
Summary
Web Inspector: RTL: add support for TimelineOverview sidebar and container la...
Devin Rousso
Reported
2017-03-13 21:21:59 PDT
.
Attachments
Patch
(5.22 KB, patch)
2017-03-13 21:32 PDT
,
Devin Rousso
bburg
: review+
Details
Formatted Diff
Diff
[Image] After Patch is applied
(217.25 KB, image/png)
2017-03-13 21:33 PDT
,
Devin Rousso
no flags
Details
Patch
(4.96 KB, patch)
2017-03-14 11:46 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2017-03-13 21:32:59 PDT
Created
attachment 304345
[details]
Patch
Devin Rousso
Comment 2
2017-03-13 21:33:21 PDT
Created
attachment 304346
[details]
[Image] After Patch is applied
Blaze Burg
Comment 3
2017-03-13 22:14:57 PDT
Comment on
attachment 304345
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=304345&action=review
r=me
> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31 > +body[dir=ltr] .timeline-overview > .tree-outline.timelines {
Can this use :matches() ?
> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:37 > +body[dir=rtl] .timeline-overview > .tree-outline.timelines {
Ditto
> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167 > + bottom: 0;
Does the ruler still look right in LTR? Or was this property unnecessary?
Devin Rousso
Comment 4
2017-03-13 22:28:20 PDT
Comment on
attachment 304345
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=304345&action=review
>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:31 >> +body[dir=ltr] .timeline-overview > .tree-outline.timelines { > > Can this use :matches() ?
Good catch!
>> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.css:167 >> + bottom: 0; > > Does the ruler still look right in LTR? Or was this property unnecessary?
I did this so that I don't have to add a reset for the other property when only setting one or the other in LTR/RTL (see lines 42 and 46). This way, I can also merge the rules together to make a single selector.
Devin Rousso
Comment 5
2017-03-14 11:46:47 PDT
Created
attachment 304407
[details]
Patch
WebKit Commit Bot
Comment 6
2017-03-14 12:07:32 PDT
Comment on
attachment 304407
[details]
Patch Clearing flags on attachment: 304407 Committed
r213924
: <
http://trac.webkit.org/changeset/213924
>
WebKit Commit Bot
Comment 7
2017-03-14 12:07:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug