WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169580
Rename RootSet to CommitSet
https://bugs.webkit.org/show_bug.cgi?id=169580
Summary
Rename RootSet to CommitSet
Ryosuke Niwa
Reported
2017-03-13 19:02:54 PDT
Rename root_sets table to commit_sets table in the database, and rename related classes elsewhere from RootSet to CommitSet to more precisely reflect what they are. This is particularly confusing once we introduce the actual custom root files user uploads.
Attachments
Renames the table
(135.45 KB, patch)
2017-03-13 19:50 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
Added migration SQL
(136.01 KB, patch)
2017-03-13 19:53 PDT
,
Ryosuke Niwa
cdumez
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2017-03-13 19:50:21 PDT
Created
attachment 304336
[details]
Renames the table
Ryosuke Niwa
Comment 2
2017-03-13 19:53:28 PDT
Created
attachment 304337
[details]
Added migration SQL
Chris Dumez
Comment 3
2017-03-14 15:45:24 PDT
Comment on
attachment 304337
[details]
Added migration SQL rs=me
Ryosuke Niwa
Comment 4
2017-03-14 16:06:43 PDT
Committed
r213952
: <
http://trac.webkit.org/changeset/213952
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug