Bug 169580 - Rename RootSet to CommitSet
Summary: Rename RootSet to CommitSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-13 19:02 PDT by Ryosuke Niwa
Modified: 2017-03-14 16:06 PDT (History)
4 users (show)

See Also:

Attachments
Renames the table (135.45 KB, patch)
2017-03-13 19:50 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Added migration SQL (136.01 KB, patch)
2017-03-13 19:53 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-03-13 19:02:54 PDT 
Rename root_sets table to commit_sets table in the database,
and rename related classes elsewhere from RootSet to CommitSet
to more precisely reflect what they are.

This is particularly confusing once we introduce the actual custom root files user uploads.
Comment 1 Ryosuke Niwa 2017-03-13 19:50:21 PDT 
Created attachment 304336 [details]
Renames the table
Comment 2 Ryosuke Niwa 2017-03-13 19:53:28 PDT 
Created attachment 304337 [details]
Added migration SQL
Comment 3 Chris Dumez 2017-03-14 15:45:24 PDT 
Comment on attachment 304337 [details]
Added migration SQL

rs=me
Comment 4 Ryosuke Niwa 2017-03-14 16:06:43 PDT 
Committed r213952: <http://trac.webkit.org/changeset/213952>