Bug 169577 – Web Inspector: More accurate Resource Timing data in Web Inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
More accurate Resource Timing data in Web Inspector

* The "responseEnd" time we show in Web Inspector comes from the Web Process instead of the responseEnd time we got from the Network Process which we use in ResourceTiming. Unify them.
* The millisecond values seems to be off in the ResourceResponse path.

[Joseph Pecoraro]

Created attachment 304325 [details]
[PATCH] Proposed Fix

[youenn fablet]

Comment on attachment 304325 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=304325&action=review

> Source/WebCore/loader/CrossOriginPreflightChecker.cpp:88
> +    InspectorInstrumentation::didFinishLoading(frame, frame->loader().documentLoader(), identifier, emptyMetrics, nullptr);

When preflight gets a response, we might be able to  get the resource loader from the cached resource.
Is there a way to get the metrics?

[Joseph Pecoraro]

(In reply to comment #2)
> Comment on attachment 304325 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304325&action=review
> 
> > Source/WebCore/loader/CrossOriginPreflightChecker.cpp:88
> > +    InspectorInstrumentation::didFinishLoading(frame, frame->loader().documentLoader(), identifier, emptyMetrics, nullptr);
> 
> When preflight gets a response, we might be able to  get the resource loader
> from the cached resource.
>
> Is there a way to get the metrics?

There should be metrics in the didFinishLoad that lead to CachedResources::notifyFinished. We just have to thread that plumbing. That said, Preflight already has a bunch of issues in Web Inspector that need to be sorted out (failures don't show up at all), so I'll leave this for that more serious task.

[WebKit Commit Bot]

Comment on attachment 304325 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 304325

Committed r213917: <http://trac.webkit.org/changeset/213917>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.