Bug 169572 - LayoutTest imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a flaky failure
Summary: LayoutTest imported/w3c/web-platform-tests/html/browsers/history/the-location...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-13 15:38 PDT by Ryan Haddad
Modified: 2020-06-16 00:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.47 KB, patch)
2020-06-15 23:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-03-13 15:38:37 PDT
LayoutTest imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash.html is a flaky failure

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r213862%20(2607)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location-interface%2Flocation_hash.html

--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-actual.txt
@@ -1,4 +1,4 @@
 
 PASS location hash 
-FAIL Setting location.hash on srcdoc iframe assert_true: Should have scrolled by more than one viewport height expected true got false
+PASS Setting location.hash on srcdoc iframe
Comment 1 Ryan Haddad 2017-03-13 15:42:44 PDT
This test appears to have been flaky on Sierra Release WK2 for a while, but it has become very flaky on macOS Debug WK1/WK2 as of 3/9/2017 11:23:08 AM @ r213645
Comment 2 Ryan Haddad 2017-03-16 22:19:30 PDT
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/214098
Comment 3 Diego Pino 2020-06-15 12:22:44 PDT
This bug is only referenced by Mac's TestExpectations. According to results.webkit.org there hasn't been a failure in this test for the last 5000 revisions.

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fhistory%2Fthe-location-interface%2Flocation_hash.html&platform=mac

Maybe the bug can be closed?
Comment 4 youenn fablet 2020-06-15 23:44:08 PDT
Created attachment 401984 [details]
Patch
Comment 5 EWS 2020-06-16 00:28:50 PDT
Committed r263080: <https://trac.webkit.org/changeset/263080>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401984 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-16 00:29:16 PDT
<rdar://problem/64396413>