Bug 169555 - [GTK] Remove dead code from previous autotools build in build-jsc
Summary: [GTK] Remove dead code from previous autotools build in build-jsc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-13 08:09 PDT by Carlos Alberto Lopez Perez
Modified: 2017-03-13 08:46 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.24 KB, patch)
2017-03-13 08:14 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-03-13 08:09:28 PDT
When the autotools build for WebKitGTK+ was removed in r166239 the function buildGtkProject() for building WebKitGTK+ with autootols was removed from Tools/Scripts/webkitdirs.pm.

However one call to it was left in build-jsc. However this never get executed because the "if (isCMakeBuild()) {}" path is executed before it and it always exits.
Comment 1 Carlos Alberto Lopez Perez 2017-03-13 08:14:19 PDT
Created attachment 304256 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-13 08:46:03 PDT
Comment on attachment 304256 [details]
Patch

Clearing flags on attachment: 304256

Committed r213845: <http://trac.webkit.org/changeset/213845>
Comment 3 WebKit Commit Bot 2017-03-13 08:46:08 PDT
All reviewed patches have been landed.  Closing bug.