Bug 169539 - WebGPU remote layer hosting
Summary: WebGPU remote layer hosting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks: 167952
  Show dependency treegraph
 
Reported: 2017-03-13 00:26 PDT by Jon Lee
Modified: 2017-03-14 14:28 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.66 KB, patch)
2017-03-13 00:44 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (10.57 KB, patch)
2017-03-13 00:45 PDT, Dean Jackson
jonlee: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2017-03-13 00:26:40 PDT
WebGPU remote layer hosting
Comment 1 Radar WebKit Bug Importer 2017-03-13 00:27:03 PDT
<rdar://problem/31005380>
Comment 2 Radar WebKit Bug Importer 2017-03-13 00:27:22 PDT
<rdar://problem/31005384>
Comment 3 Dean Jackson 2017-03-13 00:44:14 PDT
Created attachment 304235 [details]
Patch
Comment 4 Dean Jackson 2017-03-13 00:45:06 PDT
Created attachment 304236 [details]
Patch
Comment 5 Jon Lee 2017-03-13 00:49:34 PDT
Comment on attachment 304236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:897
> +            case PlatformCALayer::LayerTypeWebGLLayer:

WebGPULayer
Comment 6 Jon Lee 2017-03-13 00:50:55 PDT
Comment on attachment 304236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review

r+ with WebGL -> WebGPU fix in RemoteLayerTreeTransaction.mm.

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:302
> +#endif

ick.
Comment 7 Jon Lee 2017-03-13 00:55:37 PDT
Committed r213786.
Comment 8 Dean Jackson 2017-03-13 00:57:54 PDT
Committed r213786: <http://trac.webkit.org/changeset/213786>
Comment 9 Simon Fraser (smfr) 2017-03-13 08:15:05 PDT
Comment on attachment 304236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304236&action=review

> Source/WebCore/platform/graphics/ca/PlatformCALayer.h:77
> +        LayerTypeWebGPULayer,

Does it actually need to be its own layer type, or can we just rename LayerTypeWebGLLayer to be a bit more generic?
Comment 10 Dean Jackson 2017-03-14 14:28:42 PDT
(In reply to comment #9)
> Comment on attachment 304236 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=304236&action=review
> 
> > Source/WebCore/platform/graphics/ca/PlatformCALayer.h:77
> > +        LayerTypeWebGPULayer,
> 
> Does it actually need to be its own layer type, or can we just rename
> LayerTypeWebGLLayer to be a bit more generic?

Done in 169628