Bug 169537 – [WTF] Clean up RunLoop and WorkQueue with Seconds and Function

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[WTF] Clean up RunLoop and WorkQueue with Seconds and Function

[Yusuke Suzuki]

Created attachment 304220 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 304220 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 304220 [details]
Patch

Clearing flags on attachment: 304220

Committed r213858: <http://trac.webkit.org/changeset/213858>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Garcia Campos]

Comment on attachment 304220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304220&action=review

> Source/WTF/wtf/glib/RunLoopGLib.cpp:-198
> -    auto intervalDuration = std::chrono::duration<double>(fireInterval);
> -    auto safeDuration = std::chrono::microseconds::max();
> -    if (intervalDuration < safeDuration)
> -        safeDuration = std::chrono::duration_cast<std::chrono::microseconds>(intervalDuration);

Something like this is still needed. GSoure works with microseconds, when std::numeric_limits<double>::infinity() is passed here (like XMLHttpRequest does to disable network timeouts), we will overflow later when trying to convert infinity to microseconds

[Carlos Garcia Campos]

Comment on attachment 304220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304220&action=review

> Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:42
> -    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, duration.count()), m_dispatchQueue, BlockPtr<void ()>::fromCallable([protectedThis = makeRef(*this), function = WTFMove(function)] {
> +    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, duration.nanoseconds()), m_dispatchQueue, BlockPtr<void()>::fromCallable([protectedThis = makeRef(*this), function = WTFMove(function)] {

This could also overflow now, I think. It doesn't probably happen because dispatchAfter is never called with infinity or a long enough value.

[Yusuke Suzuki]

Reopening to attach new patch.

[Yusuke Suzuki]

Created attachment 304372 [details]
Patch

[Yusuke Suzuki]

Created attachment 304373 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 304373 [details]
Patch

This looks good to me. Thanks.

[Yusuke Suzuki]

Committed r213896: <http://trac.webkit.org/changeset/213896>