Bug 169529 - REGRESSION (r213764): Async image decoding is disabled for animated images
Summary: REGRESSION (r213764): Async image decoding is disabled for animated images
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-12 15:20 PDT by Said Abou-Hallawa
Modified: 2017-03-12 19:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2017-03-12 15:21 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-03-12 15:20:12 PDT 
The change r213764 causes the animated images to be decoded synchronously because we were calling frameImageAtIndex() with an empty sizeForDrawing but with a valid subsamplingLevel. This call is translated to be synchronous image decoding. The fix is get the current image frame without any decoding. This is because are sure that in the case of animated image, the current image frame can not be deleted.
Comment 1 Said Abou-Hallawa 2017-03-12 15:21:25 PDT 
Created attachment 304204 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-03-12 15:33:42 PDT 
<rdar://problem/31000929>
Comment 3 WebKit Commit Bot 2017-03-12 16:52:34 PDT 
Comment on attachment 304204 [details]
Patch

Clearing flags on attachment: 304204

Committed r213774: <http://trac.webkit.org/changeset/213774>
Comment 4 WebKit Commit Bot 2017-03-12 16:52:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2017-03-12 18:08:36 PDT 
Comment on attachment 304204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304204&action=review

> Source/WebCore/ChangeLog:13
> +        The change r213764 causes the animated images to be decoded synchronously
> +        because we were calling frameImageAtIndex() with an empty sizeForDrawing
> +        but with a valid subsamplingLevel. This call is translated to be synchronous
> +        image decoding. The fix is get the current image frame without any decoding.
> +        This is because are sure that in the case of animated image, the current
> +        image frame can not be deleted.

No test caught this?
Comment 6 Said Abou-Hallawa 2017-03-12 19:05:39 PDT 
Comment on attachment 304204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304204&action=review

>> Source/WebCore/ChangeLog:13
>> +        image frame can not be deleted.
> 
> No test caught this?

I will write a test since this is the second time the same problem happens and no test caught it.