Bug 169522 – REGRESSION (r211657): bisect-builds doesn't work

• Status: NEW
• Component: Tools / Tests

[Alexey Proskuryakov]

$ bisect-builds 
Undefined subroutine &main::safariPathFromSafariBundle called at Tools/Scripts/bisect-builds line 132.

For what it’s worth, I’m not sure it was working prior to that revision either (I think it was just failing differently).

[Alexey Proskuryakov]

Created attachment 304189 [details]
fix (doesn't make it work)

This looks like what it should take to fix it, but the script still doesn't work:

$ bisect-builds 
Requires Mac OS X 10.4 (Tiger) or later at /Users/ap/Safari/OpenSource/Tools/Scripts/bisect-builds line 391.

I don't understand the code that produces this error. Confirmed that $osxVersionString and $safariVersionString are as expected (10.12.3 and 10.0.3).

Looks like the script hasn’t been updated for macOS Sierra.

[Alexey Proskuryakov]

Comment on attachment 304189 [details]
fix (doesn't make it work)

View in context: https://bugs.webkit.org/attachment.cgi?id=304189&action=review

> Tools/Scripts/bisect-builds:75
> +my $safariPath = safariPath();

Actually, "/Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment" may be even more appropriate here. When bisecting with nightlies, we don't want a locally built Safari.

[Alexey Proskuryakov]

> Looks like the script hasn’t been updated for macOS Sierra.

Good point. Adding the support still doesn't make it work though. I confirmed that this nightly build works when opened manually.

    if ($osxVersion ge v10.12 && $osxVersion lt v10.13) {
        @files = grep { $_->{rev} >= 205582 } @files;
    } elsif ($osxVersion ge v10.11 && $osxVersion lt v10.12) {

$ bisect-builds

Works: r205582  Fails: r213762

Checking revision r209345 (200 builds left to test after this)...
Downloading WebKit-SVN-r209345.dmg to /Users/ap/Library/Caches/WebKit-Nightlies/trunk...
######################################################################## 100.0%
Mounting disk image and running WebKit...
LSOpenURLsWithRole() failed for the application /Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment with error -10810.
Did the bug reproduce in r209345 (yes/no/retry/broken)? ^C

[Alexey Proskuryakov]

"This" being r209345. I didn't confirm whether r205582 works, I just know that this is when the nightlies got larger.

(In reply to comment #5)

> LSOpenURLsWithRole() failed for the application
> /Applications/Safari.app/Contents/MacOS/SafariForWebKitDevelopment with
> error -10810.

This is probably because $isBundle is true even thought the above path isn’t a bundle.