Bug 169520 - Structure::willStoreValueSlow needs to keep the property table alive until the end
Summary: Structure::willStoreValueSlow needs to keep the property table alive until th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-11 22:06 PST by Filip Pizlo
Modified: 2017-03-12 15:58 PDT (History)
5 users (show)

See Also:

Attachments
the patch (3.29 KB, patch)
2017-03-11 22:09 PST, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
patch for landing (3.30 KB, patch)
2017-03-12 10:00 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-03-11 22:06:13 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-03-11 22:09:10 PST 
Created attachment 304186 [details]
the patch
Comment 2 WebKit Commit Bot 2017-03-11 22:12:23 PST 
Attachment 304186 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/HeapCell.h:76:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Michael Saboff 2017-03-11 22:55:12 PST 
Comment on attachment 304186 [details]
the patch

r=me
You may want to add that you're keeping this alive for the conservative scan.
Comment 4 Filip Pizlo 2017-03-12 10:00:35 PDT 
Created attachment 304193 [details]
patch for landing

Checking windows ews
Comment 5 WebKit Commit Bot 2017-03-12 10:03:16 PDT 
Attachment 304193 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/heap/HeapCell.h:76:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Filip Pizlo 2017-03-12 15:58:44 PDT 
Landed in r213773.