RESOLVED FIXED 169519
FTL should not flush strict arguments unless it really needs to 
https://bugs.webkit.org/show_bug.cgi?id=169519
Summary FTL should not flush strict arguments unless it really needs to
Filip Pizlo
Reported 2017-03-11 21:18:22 PST
We use flushing of arguments for a lot of different things. One of them is sloppy arguments reflection. We can easily teach the FTL not to do that for strict mode.
Attachments
the patch (4.07 KB, patch)
2017-03-11 21:22 PST, Filip Pizlo 		mark.lam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-03-11 21:22:35 PST
Created attachment 304184 [details] the patch
Build Bot
Comment 2 2017-03-11 22:00:57 PST
Comment on attachment 304184 [details] the patch Attachment 304184 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/3296400 New failing tests: mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate-phases stress/super-property-access.js.ftl-eager-no-cjit mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl stress/super-property-access.js.ftl-eager mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla
Filip Pizlo
Comment 3 2017-03-11 22:10:21 PST
(In reply to comment #2) > Comment on attachment 304184 [details] > the patch > > Attachment 304184 [details] did not pass jsc-ews (mac): > Output: http://webkit-queues.webkit.org/results/3296400 > > New failing tests: > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-dfg-eager-no-cjit-validate- > phases > stress/super-property-access.js.ftl-eager-no-cjit > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-baseline > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-no-ftl > stress/super-property-access.js.ftl-eager > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-llint > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla-ftl-eager-no-cjit-validate- > phases > mozilla-tests.yaml/ecma/Date/15.9.5.14.js.mozilla Hahahahaha! DST is happening!
Mark Lam
Comment 4 2017-03-13 10:56:10 PDT
Comment on attachment 304184 [details] the patch r=me
Filip Pizlo
Comment 5 2017-03-13 11:00:46 PDT
Landed in r213856
WebKit Commit Bot
Comment 6 2017-03-13 12:34:52 PDT
Re-opened since this is blocked by bug 169562
Mark Lam
Comment 7 2017-03-13 12:37:52 PDT
This was rolled out in r213860: <http://trac.webkit.org/changeset/213860>.
Filip Pizlo
Comment 8 2017-03-13 15:53:28 PDT
Relanded with fixes in r213876
Note You need to log in before you can comment on or make changes to this bug.