Bug 169517 – REGRESSION (r211382): Partial right-to-left text runs are painted at an offset (breaks Find indicators, Look Up, and custom ::selection style)

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

To reproduce this bug, navigate to the URL and then control-click the long word on the left, and choose Look Up “הסתבכויות” from the contextual menu. In the yellow lookup highlight, the word is offset to the right but about the width of the other word.

[Radar WebKit Bug Importer]

<rdar://problem/30996668>

I am pretty sure this was caused by the changes to FontCascade in r211382, but I haven’t confirmed it yet.

Caused by <https://trac.webkit.org/r211382>, the fix for bug 166013.

Here is a test case you can use that doesn’t depend on lookup:

<style>
	::selection { color: green; }
</style>
<bdo id=target dir=rtl>neerg si noitceleS</bdo>
<script>
	let textNode = document.getElementById("target").firstChild;
	getSelection().setBaseAndExtent(textNode, 0, textNode, 5)
</script>

[Tim Horton]

Radar is actually rdar://problem/30652443

[Myles C. Maxfield]

Created attachment 308803 [details]
Patch

[Build Bot]

Comment on attachment 308803 [details]
Patch

Attachment 308803 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3656252

New failing tests:
fast/text/complex-text-selection.html

[Build Bot]

Created attachment 308809 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 308828 [details]
Patch

[Myles C. Maxfield]

Created attachment 308831 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 308831 [details]
Patch

Clearing flags on attachment: 308831

Committed r216088: <http://trac.webkit.org/changeset/216088>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jon Lee]

*** Bug 171658 has been marked as a duplicate of this bug. ***