Bug 169500 - Add SPI to set NSURLSessionConfiguration.allowsCellularAccess from _WKProcessPoolConfiguration
Summary: Add SPI to set NSURLSessionConfiguration.allowsCellularAccess from _WKProcess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-10 18:55 PST by Alex Christensen
Modified: 2017-03-10 19:25 PST (History)
0 users

See Also:


Attachments
Patch (8.90 KB, patch)
2017-03-10 18:57 PST, Alex Christensen
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-03-10 18:55:16 PST
Add SPI to set NSURLSessionConfiguration.allowsCellularAccess from _WKProcessPoolConfiguration
Comment 1 Alex Christensen 2017-03-10 18:57:22 PST
Created attachment 304114 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-10 19:21:50 PST
Comment on attachment 304114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304114&action=review

r=me

> Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:54
> +@property (nonatomic) BOOL allowsCellularAccess WK_API_AVAILABLE(ios(WK_IOS_TBA));

Needs macOS availability.
Comment 3 Joseph Pecoraro 2017-03-10 19:22:25 PST
Comment on attachment 304114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304114&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:54
>> +@property (nonatomic) BOOL allowsCellularAccess WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> Needs macOS availability.

And if you are here you could move this up by the secondaryIdentifier like the rest of the patch.
Comment 4 Alex Christensen 2017-03-10 19:25:10 PST
http://trac.webkit.org/r213747