Bug 169490 - [Win] Re-export a few symbols needed for backwards compatibility
Summary: [Win] Re-export a few symbols needed for backwards compatibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 169545
  Show dependency tree / graph
 
Reported: 2017-03-10 16:00 PST by Brent Fulgham
Modified: 2017-03-15 09:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.82 KB, patch)
2017-03-10 16:02 PST, Brent Fulgham 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-03-10 16:00:17 PST 
Re-introduce an old hack needed to support very old software.
Comment 1 Brent Fulgham 2017-03-10 16:02:07 PST 
Created attachment 304089 [details]
Patch
Comment 2 Brent Fulgham 2017-03-10 16:02:35 PST 
Comment on attachment 304089 [details]
Patch

Patch was previously reviewed by Dean Jackson and landed on a branch. Merging this back to mainline.
Comment 3 Brent Fulgham 2017-03-10 16:02:52 PST 
Uploading to Bugzilla to perform EWS run.
Comment 4 WebKit Commit Bot 2017-03-10 16:11:16 PST 
Attachment 304089 [details] did not pass style-queue:


ERROR: Source/WebKit/win/WebKitDLL.cpp:272:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit/win/WebKitDLL.cpp:287:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2017-03-10 16:59:13 PST 
Committed in r213737: <https://trac.webkit.org/changeset/213737>.
Comment 6 Csaba Osztrogonác 2017-03-11 13:44:05 PST 
(In reply to comment #3)
> Uploading to Bugzilla to perform EWS run.

And you landed with red EWS and broke the Apple Windows build ...
Comment 7 Brent Fulgham 2017-03-13 13:46:51 PDT 
Build fix to handle new warning-as-error setting:

Committed r213847: <http://trac.webkit.org/changeset/213847>
Comment 8 Per Arne Vollan 2017-03-13 14:54:18 PDT 
(In reply to comment #7)
> Build fix to handle new warning-as-error setting:
> 
> Committed r213847: <http://trac.webkit.org/changeset/213847>

I believe we need this as well: <http://trac.webkit.org/changeset/213846>.