Bug 169488 - Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
Summary: Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-10 15:33 PST by Matt Baker
Modified: 2017-03-10 17:56 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.72 KB, patch)
2017-03-10 15:35 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-10 15:33:38 PST 
Summary:
Only show "Break on..." menu if backend supports DOM breakpoints.

Need to add a check to DOMTreeElement.
Comment 1 Matt Baker 2017-03-10 15:35:24 PST 
Created attachment 304086 [details]
Patch
Comment 2 Joseph Pecoraro 2017-03-10 17:15:05 PST 
Comment on attachment 304086 [details]
Patch

r=me
Comment 3 Devin Rousso 2017-03-10 17:15:58 PST 
Comment on attachment 304086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304086&action=review

> Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js:47
> +        console.assert(WebInspector.domDebuggerManager.supported);

I feel like it would be much simpler and less mistake prone in future changes if we added the support check inside this function instead of at the call sites.  Considering the fact that multiple separators in a row in a context menu are collapsed, I think this may be the better (and possibly more centralized) approach.
Comment 4 WebKit Commit Bot 2017-03-10 17:56:11 PST 
Comment on attachment 304086 [details]
Patch

Clearing flags on attachment: 304086

Committed r213744: <http://trac.webkit.org/changeset/213744>
Comment 5 WebKit Commit Bot 2017-03-10 17:56:15 PST 
All reviewed patches have been landed.  Closing bug.