Bug 169472 – Move libwebrtc backend to using tracks

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

We should move to the newer libwebrtc API

[youenn fablet]

Created attachment 304047 [details]
Patch

[WebKit Commit Bot]

Attachment 304047 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:209:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:215:  media_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:217:  stream_ids is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 304052 [details]
Patch

[WebKit Commit Bot]

Attachment 304052 [details] did not pass style-queue:


ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:209:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:215:  media_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/testing/MockLibWebRTCPeerConnection.h:217:  stream_ids is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 304052 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304052&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:177
> +    if (source.type() == RealtimeMediaSource::Audio) {

I think Type should be made an enum class instead of an enum and this should be made a switch statement.  Right now we are assuming that if a media source is not audio it is video, when there are three values in RealtimeMediaSource::Type.  That might be a good assumption, but I think switching on enums is good practice.

[youenn fablet]

Created attachment 304071 [details]
Patch for landing

[youenn fablet]

Created attachment 304092 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 304071 [details]
Patch for landing

Clearing flags on attachment: 304071

Committed r213736: <http://trac.webkit.org/changeset/213736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.