NEW169471
webkit-patch upload does not detect file renames when using git 
https://bugs.webkit.org/show_bug.cgi?id=169471
Summary webkit-patch upload does not detect file renames when using git
Srinivasan Vijayaraghavan
Reported 2017-03-10 09:01:50 PST
Running git diff locally shows that a file has been renamed, but the patch actually uploaded by `webkit-patch upload` uses git diff with --no-renames to generate the patch (See create_patch() in webkitpy/common/checkout/scm/git.py). As a result, the uploaded patch shows a deleted file and a new file, thereby losing history. That --no-renames flag was added in 2011 as part of https://bugs.webkit.org/show_bug.cgi?id=48075. Filing this bug now since I'm not sure if those issues still exist, or if they have since become feasible to fix.
Attachments
Add attachment proposed patch, testcase, etc.
Note You need to log in before you can comment on or make changes to this bug.