Bug 169465 - imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html is unreliable
Summary: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-eleme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 149157
  Show dependency tree / graph
 
Reported: 2017-03-10 05:15 PST by Antti Koivisto
Modified: 2017-10-23 23:04 PDT (History)
2 users (show)

See Also:

Attachments
patch (38.70 KB, patch)
2017-03-10 05:20 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-03-10 05:15:04 PST 
It shows all tests passing but that is a bug. We don't even support all the unit types. The test occasionally fails when reloading, that failing results are actually the correct ones.
Comment 1 Antti Koivisto 2017-03-10 05:20:03 PST 
Created attachment 304039 [details]
patch
Comment 2 WebKit Commit Bot 2017-03-10 07:38:44 PST 
Comment on attachment 304039 [details]
patch

Clearing flags on attachment: 304039

Committed r213711: <http://trac.webkit.org/changeset/213711>
Comment 3 WebKit Commit Bot 2017-03-10 07:38:48 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryosuke Niwa 2017-10-23 23:00:23 PDT 
Comment on attachment 304039 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304039&action=review

> Source/WebCore/css/parser/SizesAttributeParser.cpp:75
> +    if (m_document.ownerElement())
> +        m_document.ownerElement()->document().updateLayoutIgnorePendingStylesheets();

It's not safe to update layout here because this function is getting called within Node::insertedInto,
and updating layout could run arbitrary author scripts :(