Bug 169459 – [QuickLook] Add WKNavigationDelegate SPI to notify when a password is requested

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[QuickLook] Add WKNavigationDelegate SPI to notify when a password is requested

[Andy Estes]

rdar://problem/30621913

[Andy Estes]

Created attachment 304022 [details]
Patch

[Alex Christensen]

Comment on attachment 304022 [details]
Patch

How does one respond to such a notification?

[Andy Estes]

(In reply to comment #3)
> Comment on attachment 304022 [details]
> Patch
> 
> How does one respond to such a notification?

One doesn't. WebKit handles the UI for password entry. This tells the client that a navigation requires a password from the user to proceed; it's not meant to delegate the password UI itself to the client.

[Andy Estes]

More specifically, in some cases the client will show a spinner UI on top of the web view until a navigation finishes. But if the document is password-protected then the navigation won't finish until the user enters the password, which they can't do because the spinner UI is obscuring the password UI. This delegate method lets the client hide the spinner at the right time.

[Alex Christensen]

Comment on attachment 304022 [details]
Patch

The client ought to do the password UI, but if that's the way quick look works then this is what we have to do right now.

[WebKit Commit Bot]

Comment on attachment 304022 [details]
Patch

Clearing flags on attachment: 304022

Committed r213725: <http://trac.webkit.org/changeset/213725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.