https://github.com/w3c/csswg-drafts/commit/d93fbf496e170fa94dc8b32fb62958ad2cf57842 We need to spend more time figuring out how to treat italic and oblique the same (or just stop trying to treat them the same and implement them correctly separately)
Created attachment 310938 [details] Needs tests
Created attachment 310952 [details] Patch
Comment on attachment 310952 [details] Patch Attachment 310952 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3796974 New failing tests: fast/text/font-style-parse.html
Created attachment 310961 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 310963 [details] Patch
<rdar://problem/32341177>
Comment on attachment 310963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310963&action=review > Source/WebCore/css/FontFace.cpp:293 > + auto minimum = ComputedStyleExtractor::fontStyleFromStyleValue(style.minimum, true); > + auto maximum = ComputedStyleExtractor::fontStyleFromStyleValue(style.maximum, true); Would read better with an enum argument. Enum could mention italic/oblique which would make this all easier to follow.
Committed r217272: <http://trac.webkit.org/changeset/217272>