Bug 169439 – [iOS] Add SPI to print to a single tall PDF page

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Add SPI to print to a single tall PDF page

[Andy Estes]

rdar://problem/30120532

[Andy Estes]

Created attachment 303982 [details]
Patch

[Tim Horton]

Comment on attachment 303982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303982&action=review

> Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.mm:38
> +@interface UIPrintPageRenderer ()
> +@property (nonatomic) CGRect paperRect;
> +@property (nonatomic) CGRect printableRect;
> +@end

Should be in UIKitSPI.

> Source/WebKit2/UIProcess/ios/WKContentView.mm:698
> +        static const CGFloat maximumPDFHeight = 200 * 72; // maximum PDF height for a single page is 200 inches

O... kay. Is that a PDF spec thing, or a CGPDF thing, or what? Can we (at some point) get it from somewhere isntead of hardcoding it?

[Andy Estes]

(In reply to comment #3)
> Comment on attachment 303982 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=303982&action=review
> 
> > Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.mm:38
> > +@interface UIPrintPageRenderer ()
> > +@property (nonatomic) CGRect paperRect;
> > +@property (nonatomic) CGRect printableRect;
> > +@end
> 
> Should be in UIKitSPI.

It's not SPI :(

> 
> > Source/WebKit2/UIProcess/ios/WKContentView.mm:698
> > +        static const CGFloat maximumPDFHeight = 200 * 72; // maximum PDF height for a single page is 200 inches
> 
> O... kay. Is that a PDF spec thing, or a CGPDF thing, or what? Can we (at
> some point) get it from somewhere isntead of hardcoding it?

I believe it's a PDF spec thing. I'll investigate whether we can get this elsewhere.

[WebKit Commit Bot]

Comment on attachment 303982 [details]
Patch

Clearing flags on attachment: 303982

Committed r213674: <http://trac.webkit.org/changeset/213674>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.