Bug 169437 - WebAssembly: Enable fast memory for WK2
Summary: WebAssembly: Enable fast memory for WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-09 13:19 PST by Keith Miller
Modified: 2017-03-09 16:57 PST (History)
10 users (show)

See Also:


Attachments
Patch (3.98 KB, patch)
2017-03-09 13:20 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (4.24 KB, patch)
2017-03-09 14:04 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (4.08 KB, patch)
2017-03-09 14:17 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-03-09 13:19:14 PST
WebAssembly: Enable fast memory for WK2
Comment 1 Keith Miller 2017-03-09 13:20:34 PST
Created attachment 303973 [details]
Patch
Comment 2 Saam Barati 2017-03-09 13:44:50 PST
Comment on attachment 303973 [details]
Patch

I'll let folks familiar with WK2 give the thumbs up here.
Comment 3 Keith Miller 2017-03-09 14:04:28 PST
Created attachment 303984 [details]
Patch
Comment 4 Tim Horton 2017-03-09 14:08:05 PST
Comment on attachment 303984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303984&action=review

> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:154
> +#if ENABLE(WEBASSEMBLY)
> +    JSC::Wasm::enableFastMemory();
> +#endif

Also possible you want to put this in WebProcess::initializeWebProcess if it is not a Cocoa-only feature. Either way, r=me.
Comment 5 Keith Miller 2017-03-09 14:14:52 PST
Comment on attachment 303984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303984&action=review

>> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:154
>> +#endif
> 
> Also possible you want to put this in WebProcess::initializeWebProcess if it is not a Cocoa-only feature. Either way, r=me.

Ah, good call. Changed.
Comment 6 Keith Miller 2017-03-09 14:17:05 PST
Created attachment 303991 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-03-09 16:57:12 PST
Comment on attachment 303991 [details]
Patch for landing

Clearing flags on attachment: 303991

Committed r213692: <http://trac.webkit.org/changeset/213692>
Comment 8 WebKit Commit Bot 2017-03-09 16:57:17 PST
All reviewed patches have been landed.  Closing bug.