Bug 169425 - [WK2] Only report background WebProcesses as unresponsive in the background after 90 seconds
Summary: [WK2] Only report background WebProcesses as unresponsive in the background a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 169456
  Show dependency tree / graph
 
Reported: 2017-03-09 12:28 PST by Chris Dumez
Modified: 2017-03-13 04:16 PDT (History)
12 users (show)

See Also:

Attachments
Patch (24.08 KB, patch)
2017-03-10 10:05 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-03-09 12:28:30 PST 
Only report background WebProcesses as unresponsive in the background after 90 seconds, instead of the usual 3 seconds for foreground ones.
Comment 1 Radar WebKit Bug Importer 2017-03-09 12:29:02 PST 
<rdar://problem/30954003>
Comment 2 Alexey Proskuryakov 2017-03-09 14:36:51 PST 
When does this kick in? I would expect background processes to never be marked as unresponsive, as they don't get events.
Comment 3 Chris Dumez 2017-03-09 14:38:12 PST 
(In reply to comment #2)
> When does this kick in? I would expect background processes to never be
> marked as unresponsive, as they don't get events.

This is a follow-up to:
http://trac.webkit.org/r212832
http://trac.webkit.org/r212619

We do mark background processes as unresponsive now.
Comment 4 Chris Dumez 2017-03-10 10:05:56 PST 
Created attachment 304050 [details]
Patch
Comment 5 Andreas Kling 2017-03-13 03:48:12 PDT 
Comment on attachment 304050 [details]
Patch

r=me
This makes me wonder if 30 seconds isn't too aggressive for checking memory usage in background tabs, too.
Comment 6 WebKit Commit Bot 2017-03-13 04:16:33 PDT 
Comment on attachment 304050 [details]
Patch

Clearing flags on attachment: 304050

Committed r213824: <http://trac.webkit.org/changeset/213824>
Comment 7 WebKit Commit Bot 2017-03-13 04:16:39 PDT 
All reviewed patches have been landed.  Closing bug.