Bug 169416 – Minimal build is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Minimal build is broken:

JSBuiltinInternalFunctions::JSBuiltinInternalFunctions(JSC::VM& vm)
#if ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
    : m_vm(vm)
#endif // ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
#if ENABLE(FETCH_API)
    , m_fetchInternals(m_vm)
#endif // ENABLE(FETCH_API)
#if ENABLE(WEB_RTC)
    , m_rtcPeerConnectionInternals(m_vm)
#endif // ENABLE(WEB_RTC)
#if ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API)
    , m_readableByteStreamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API)
#if ENABLE(READABLE_STREAM_API)
    , m_readableStreamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API)
#if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
    , m_streamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
#if ENABLE(WRITABLE_STREAM_API)
    , m_writableStreamInternals(m_vm)
#endif // ENABLE(WRITABLE_STREAM_API)
    , m_jsDOMBindingInternals(m_vm)
{
    UNUSED_PARAM(vm);
}


If all these features are disabled, then the initialization list no longer starts with a ':' and m_jsDOMBindingInternals(m_vm) is referring to m_vm which does not exist.

[youenn fablet]

Created attachment 303924 [details]
Patch

[WebKit Commit Bot]

This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)

[Chris Dumez]

Is the GTK failure real?

[Mark Lam]

Sorry, I closed the wrong bug.

[youenn fablet]

(In reply to comment #3)
> Is the GTK failure real?

It seems so although the log does not give any hint about the actual issue.

[Chris Dumez]

(In reply to comment #5)
> (In reply to comment #3)
> > Is the GTK failure real?
> 
> It seems so although the log does not give any hint about the actual issue.

Could be an incremental build issue. We've had such issues on the GTK EWS recently. All other EWS is green so it looks good to me.

[youenn fablet]

Let's see if GTK bots like it or not then.

[WebKit Commit Bot]

Comment on attachment 303924 [details]
Patch

Clearing flags on attachment: 303924

Committed r213680: <http://trac.webkit.org/changeset/213680>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[youenn fablet]

GTK bots seem happy with the patch.