Bug 169416 - Minimal build is broken
Summary: Minimal build is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-09 09:16 PST by Chris Dumez
Modified: 2017-03-09 16:07 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.83 KB, patch)
2017-03-09 09:37 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-03-09 09:16:58 PST 
Minimal build is broken:

JSBuiltinInternalFunctions::JSBuiltinInternalFunctions(JSC::VM& vm)
#if ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
    : m_vm(vm)
#endif // ENABLE(READABLE_STREAM_API) || ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API) || ENABLE(WEB_RTC) || ENABLE(FETCH_API) || ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
#if ENABLE(FETCH_API)
    , m_fetchInternals(m_vm)
#endif // ENABLE(FETCH_API)
#if ENABLE(WEB_RTC)
    , m_rtcPeerConnectionInternals(m_vm)
#endif // ENABLE(WEB_RTC)
#if ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API)
    , m_readableByteStreamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API) && ENABLE(READABLE_BYTE_STREAM_API)
#if ENABLE(READABLE_STREAM_API)
    , m_readableStreamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API)
#if ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
    , m_streamInternals(m_vm)
#endif // ENABLE(READABLE_STREAM_API) || ENABLE(WRITABLE_STREAM_API)
#if ENABLE(WRITABLE_STREAM_API)
    , m_writableStreamInternals(m_vm)
#endif // ENABLE(WRITABLE_STREAM_API)
    , m_jsDOMBindingInternals(m_vm)
{
    UNUSED_PARAM(vm);
}


If all these features are disabled, then the initialization list no longer starts with a ':' and m_jsDOMBindingInternals(m_vm) is referring to m_vm which does not exist.
Comment 1 youenn fablet 2017-03-09 09:37:34 PST 
Created attachment 303924 [details]
Patch
Comment 2 WebKit Commit Bot 2017-03-09 09:39:49 PST 
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment 3 Chris Dumez 2017-03-09 13:02:15 PST 
Is the GTK failure real?
Comment 4 Mark Lam 2017-03-09 13:08:49 PST 
Sorry, I closed the wrong bug.
Comment 5 youenn fablet 2017-03-09 13:10:32 PST 
(In reply to comment #3)
> Is the GTK failure real?

It seems so although the log does not give any hint about the actual issue.
Comment 6 Chris Dumez 2017-03-09 13:11:49 PST 
(In reply to comment #5)
> (In reply to comment #3)
> > Is the GTK failure real?
> 
> It seems so although the log does not give any hint about the actual issue.

Could be an incremental build issue. We've had such issues on the GTK EWS recently. All other EWS is green so it looks good to me.
Comment 7 youenn fablet 2017-03-09 14:49:50 PST 
Let's see if GTK bots like it or not then.
Comment 8 WebKit Commit Bot 2017-03-09 15:14:23 PST 
Comment on attachment 303924 [details]
Patch

Clearing flags on attachment: 303924

Committed r213680: <http://trac.webkit.org/changeset/213680>
Comment 9 WebKit Commit Bot 2017-03-09 15:14:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 youenn fablet 2017-03-09 16:07:49 PST 
GTK bots seem happy with the patch.