Bug 169410 - Simple line layout: Add top level pagination support.
Summary: Simple line layout: Add top level pagination support.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-09 05:01 PST by zalan
Modified: 2017-03-09 07:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.00 KB, patch)
2017-03-09 05:20 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2017-03-09 05:54 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-03-09 05:01:43 PST 
rdar://problem/28536227
Comment 1 zalan 2017-03-09 05:20:38 PST 
Created attachment 303907 [details]
Patch
Comment 2 Antti Koivisto 2017-03-09 05:24:58 PST 
Comment on attachment 303907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303907&action=review

> Source/WebCore/rendering/SimpleLineLayoutPagination.cpp:101
> +    if ((!lineBreakIndex && line.height < flow.pageLogicalHeightForOffset(line.top))
> +        || (!style.hasAutoOrphans() && style.orphans() > (short)lineBreakIndex)) {

This might be more readable with some informatively named bool variables.
Comment 3 zalan 2017-03-09 05:54:50 PST 
Created attachment 303914 [details]
Patch
Comment 4 WebKit Commit Bot 2017-03-09 07:25:15 PST 
Comment on attachment 303914 [details]
Patch

Clearing flags on attachment: 303914

Committed r213639: <http://trac.webkit.org/changeset/213639>
Comment 5 WebKit Commit Bot 2017-03-09 07:25:21 PST 
All reviewed patches have been landed.  Closing bug.