Bug 169407 - Web Automation: automation commands hang when trying to navigate go/back and it's not possible
Summary: Web Automation: automation commands hang when trying to navigate go/back and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-09 01:54 PST by Carlos Garcia Campos
Modified: 2017-05-12 10:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.82 KB, patch)
2017-03-09 01:58 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-03-09 01:54:27 PST 
Trying to navigate back or forward when there are no back/forward items makes the web driver to hang, because navigation callback is never called.
Comment 1 Carlos Garcia Campos 2017-03-09 01:58:25 PST 
Created attachment 303901 [details]
Patch
Comment 2 BJ Burg 2017-03-10 15:09:32 PST 
Comment on attachment 303901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303901&action=review

r=me as well, nice catch.

> Source/WebKit2/ChangeLog:8
> +        Trying to navigate back or forward when there are no back/forward items makes the web driver to hang, because

s/the web driver/automation command(s)/

There is no mention of WebDriver anywhere in the code, because WebAutomationSession and friends are intentionally isolated from WebDriver API and spec concerns. So I'd prefer you not plaster the name all over. =)
Comment 3 Carlos Garcia Campos 2017-03-13 02:21:49 PDT 
Committed r213790: <http://trac.webkit.org/changeset/213790>
Comment 4 BJ Burg 2017-05-12 10:06:29 PDT 
<rdar://problem/30288513>