Bug 169404 - Fix DataInteraction guards
Summary: Fix DataInteraction guards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 21:22 PST by Megan Gardner
Modified: 2017-03-09 13:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2017-03-08 21:23 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2017-03-09 10:12 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2017-03-09 10:34 PST, Megan Gardner 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-03-08 21:22:56 PST 
Fix DataInteraction guards
Comment 1 Megan Gardner 2017-03-08 21:23:17 PST 
Created attachment 303895 [details]
Patch
Comment 2 Megan Gardner 2017-03-09 10:12:12 PST 
Created attachment 303930 [details]
Patch
Comment 3 Wenson Hsieh 2017-03-09 10:25:40 PST 
Comment on attachment 303930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303930&action=review

> Source/WebKit/mac/WebCoreSupport/WebDragClient.mm:217
> +#endif

Does this #endif here correspond to the #if PLATFORM(MAC) above? This looks like it might cause WebDragClient::declareAndWriteAttachment to be implemented twice.
Comment 4 Megan Gardner 2017-03-09 10:34:29 PST 
Created attachment 303935 [details]
Patch
Comment 5 Wenson Hsieh 2017-03-09 10:36:08 PST 
Comment on attachment 303935 [details]
Patch

r=mews
Comment 6 Megan Gardner 2017-03-09 13:20:00 PST 
https://trac.webkit.org/r213660