Bug 169391 - REGRESSION(r213564): Netflix does not play content
Summary: REGRESSION(r213564): Netflix does not play content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: All macOS 10.12
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 169331
Blocks:
  Show dependency tree / graph
 
Reported: 2017-03-08 16:15 PST by Brent Fulgham
Modified: 2017-03-08 17:46 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2017-03-08 16:26 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (4.73 KB, patch)
2017-03-08 16:55 PST, Brent Fulgham 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-03-08 16:15:40 PST 
In Bug 169331 I locked down the accessible IOKit properties too far, and blocked some elements needed to support Netflix.

This patch adds the missing IOKit properties.
Comment 1 Brent Fulgham 2017-03-08 16:16:03 PST 
<rdar://problem/30930190>
Comment 2 Brent Fulgham 2017-03-08 16:26:28 PST 
Created attachment 303862 [details]
Patch
Comment 3 Sam Weinig 2017-03-08 16:29:39 PST 
Comment on attachment 303862 [details]
Patch

This seems like something that should be testable.  Can a test be added?
Comment 4 Brent Fulgham 2017-03-08 16:55:35 PST 
Created attachment 303867 [details]
Patch
Comment 5 Brent Fulgham 2017-03-08 17:02:06 PST 
(In reply to comment #3)
> Comment on attachment 303862 [details]
> Patch
> 
> This seems like something that should be testable.  Can a test be added?

The Media team is apparently working on something to support this, but no such infrastructure exists.

To make matters worse, the types of IOKit properties being accessed seem to be a function of the hardware, so I might have to do more wildcarding to avoid breaking untested hardware configurations.
Comment 6 Brent Fulgham 2017-03-08 17:28:15 PST 
Committed r213611: <http://trac.webkit.org/changeset/213611>