WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169365
WebGPU: Backend - Textures and TextureDescriptors
https://bugs.webkit.org/show_bug.cgi?id=169365
Summary
WebGPU: Backend - Textures and TextureDescriptors
Dean Jackson
Reported
2017-03-08 13:23:14 PST
Implement Buffers, Textures and TextureDescriptors
Attachments
Patch
(32.74 KB, patch)
2017-03-10 14:29 PST
,
Dean Jackson
jonlee
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2017-03-08 13:30:34 PST
<
rdar://problem/30928716
>
Dean Jackson
Comment 2
2017-03-10 14:29:42 PST
Created
attachment 304079
[details]
Patch
Anders Carlsson
Comment 3
2017-03-10 14:49:44 PST
Comment on
attachment 304079
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=304079&action=review
> Source/WebCore/platform/graphics/cocoa/GPUTextureDescriptorMetal.mm:48 > + if (!m_textureDescriptor) > + return 0; > + return [m_textureDescriptor width];
No need to check for nil here - messaging nil will already do the right thing. (Here and all the other getter/setters). Unless you want to assert that there's a texture descriptor.
Dean Jackson
Comment 4
2017-03-10 14:56:42 PST
Committed
r213731
: <
http://trac.webkit.org/changeset/213731
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug