Bug 169365 - WebGPU: Backend - Textures and TextureDescriptors
Summary: WebGPU: Backend - Textures and TextureDescriptors
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Blocks: 167952
  Show dependency treegraph
Reported: 2017-03-08 13:23 PST by Dean Jackson
Modified: 2017-03-10 14:56 PST (History)
2 users (show)

See Also:

Patch (32.74 KB, patch)
2017-03-10 14:29 PST, Dean Jackson
jonlee: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-03-08 13:23:14 PST
Implement Buffers, Textures and TextureDescriptors
Comment 1 Dean Jackson 2017-03-08 13:30:34 PST
Comment 2 Dean Jackson 2017-03-10 14:29:42 PST
Created attachment 304079 [details]
Comment 3 Anders Carlsson 2017-03-10 14:49:44 PST
Comment on attachment 304079 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=304079&action=review

> Source/WebCore/platform/graphics/cocoa/GPUTextureDescriptorMetal.mm:48
> +    if (!m_textureDescriptor)
> +        return 0;
> +    return [m_textureDescriptor width];

No need to check for nil here - messaging nil will already do the right thing. (Here and all the other getter/setters).

Unless you want to assert that there's a texture descriptor.
Comment 4 Dean Jackson 2017-03-10 14:56:42 PST
Committed r213731: <http://trac.webkit.org/changeset/213731>