Bug 169364 - Guard Credential Management implementation behind a runtime enabled feature flag
Summary: Guard Credential Management implementation behind a runtime enabled feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on: 168616
Blocks: 167375
  Show dependency tree / graph
 
Reported: 2017-03-08 13:10 PST by Daniel Bates
Modified: 2017-05-11 20:00 PDT (History)
12 users (show)

See Also:

Attachments
Patch (37.95 KB, patch)
2017-03-08 13:14 PST, Daniel Bates 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-03-08 13:10:04 PST 
Move Credential Management implementation behind a runtime enabled flag so that we do not expose it before it is ready.
Comment 1 Daniel Bates 2017-03-08 13:14:58 PST 
Created attachment 303832 [details]
Patch
Comment 2 Brent Fulgham 2017-03-08 14:40:12 PST 
Comment on attachment 303832 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303832&action=review

r=me. Thank you for taking care of this!

> Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h:480
> +

Extra whitespace.
Comment 3 Daniel Bates 2017-03-09 14:40:33 PST 
Committed r213676: <http://trac.webkit.org/changeset/213676>
Comment 4 Radar WebKit Bug Importer 2017-03-09 14:40:59 PST 
<rdar://problem/30957588>
Comment 5 Daniel Bates 2017-03-09 14:48:45 PST 
(In reply to comment #4)
> <rdar://problem/30957588>

Disregard this comment. The radar associated with this bug is ...
Comment 6 Daniel Bates 2017-03-09 14:48:53 PST 
<rdar://problem/30957425>
Comment 7 Daniel Bates 2017-03-09 14:50:00 PST 
Reverted some character conversions that TextMate introduced into the JavaScriptCore ChangeLog entry and committed this in <http://trac.webkit.org/changeset/213677>.
Comment 8 Daniel Bates 2017-03-09 17:09:10 PST 
Committed attempt to fix the WebKit2 test bots in <http://trac.webkit.org/changeset/213694>