WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169364
Guard Credential Management implementation behind a runtime enabled feature flag
https://bugs.webkit.org/show_bug.cgi?id=169364
Summary
Guard Credential Management implementation behind a runtime enabled feature flag
Daniel Bates
Reported
2017-03-08 13:10:04 PST
Move Credential Management implementation behind a runtime enabled flag so that we do not expose it before it is ready.
Attachments
Patch
(37.95 KB, patch)
2017-03-08 13:14 PST
,
Daniel Bates
bfulgham
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2017-03-08 13:14:58 PST
Created
attachment 303832
[details]
Patch
Brent Fulgham
Comment 2
2017-03-08 14:40:12 PST
Comment on
attachment 303832
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=303832&action=review
r=me. Thank you for taking care of this!
> Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h:480 > +
Extra whitespace.
Daniel Bates
Comment 3
2017-03-09 14:40:33 PST
Committed
r213676
: <
http://trac.webkit.org/changeset/213676
>
Radar WebKit Bug Importer
Comment 4
2017-03-09 14:40:59 PST
<
rdar://problem/30957588
>
Daniel Bates
Comment 5
2017-03-09 14:48:45 PST
(In reply to
comment #4
)
> <
rdar://problem/30957588
>
Disregard this comment. The radar associated with this bug is ...
Daniel Bates
Comment 6
2017-03-09 14:48:53 PST
<
rdar://problem/30957425
>
Daniel Bates
Comment 7
2017-03-09 14:50:00 PST
Reverted some character conversions that TextMate introduced into the JavaScriptCore ChangeLog entry and committed this in <
http://trac.webkit.org/changeset/213677
>.
Daniel Bates
Comment 8
2017-03-09 17:09:10 PST
Committed attempt to fix the WebKit2 test bots in <
http://trac.webkit.org/changeset/213694
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug