Bug 169352 – Implement stroke-color CSS property.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Per Arne Vollan]

Implement stroke-color CSS property, see https://drafts.fxtf.org/paint/.

[Per Arne Vollan]

Created attachment 303809 [details]
Patch

[Per Arne Vollan]

Created attachment 303953 [details]
Patch

[Jon Lee]

Per, is this ready to be reviewed?
I think we need the same kind of tests for checking the fallback behavior as you did for stroke-width.

[Per Arne Vollan]

(In reply to comment #3)
> Per, is this ready to be reviewed?
> I think we need the same kind of tests for checking the fallback behavior as
> you did for stroke-width.

Thanks! I will add a fallback test. I think the patch needs a little more work before it is ready to be reviewed :)

[Per Arne Vollan]

I will make the patch ready for review soon :)

[Per Arne Vollan]

Created attachment 305966 [details]
Patch

[Per Arne Vollan]

Perhaps it would be better to just define stroke-color as an alias of -webkit-text-stroke-color (or vice versa)?

[Jon Lee]

(In reply to Per Arne Vollan from comment #7)
> Perhaps it would be better to just define stroke-color as an alias of
> -webkit-text-stroke-color (or vice versa)?

Both color and width should be treated the same. I'm ok with this approach for now.

[Jon Lee]

Comment on attachment 305966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305966&action=review

> Source/WebCore/css/CSSProperties.json:3056
> +        },

I think this needs to be adjusted per 170643.

> Source/WebCore/rendering/style/StyleRareInheritedData.cpp:337
> +        && visitedLinkStrokeColor == o.visitedLinkStrokeColor

We need tests that include :visited links.

[Per Arne Vollan]

Created attachment 306817 [details]
Patch

[Per Arne Vollan]

(In reply to Jon Lee from comment #9)
> Comment on attachment 305966 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=305966&action=review
> 
> > Source/WebCore/css/CSSProperties.json:3056
> > +        },
> 
> I think this needs to be adjusted per 170643.
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:337
> > +        && visitedLinkStrokeColor == o.visitedLinkStrokeColor
> 
> We need tests that include :visited links.

Thanks for reviewing! I have added a new test.

[Jon Lee]

Comment on attachment 306817 [details]
Patch

Per, could we add tests or extend existing tests to check getComputedStyle results for all of the CSS properties you've added, particularly wrt visited links?

[WebKit Commit Bot]

Comment on attachment 306817 [details]
Patch

Clearing flags on attachment: 306817

Committed r215261: <http://trac.webkit.org/changeset/215261>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Per Arne Vollan]

rdar://problem/30754817

[Per Arne Vollan]

(In reply to Jon Lee from comment #12)
> Comment on attachment 306817 [details]
> Patch
> 
> Per, could we add tests or extend existing tests to check getComputedStyle
> results for all of the CSS properties you've added, particularly wrt visited
> links?

Yes, I will look into that in a separate patch. Thanks for reviewing!