Bug 169350 - REGRESSION (r212998): Web Inspector: DetailsSections with options have broken layout
Summary: REGRESSION (r212998): Web Inspector: DetailsSections with options have broken...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-08 02:49 PST by Matt Baker
Modified: 2017-03-23 09:41 PDT (History)
3 users (show)

See Also:


Attachments
[Image] Watch Expressions section (41.58 KB, image/png)
2017-03-08 02:58 PST, Matt Baker
no flags Details
[Image] Pause Reason section (59.21 KB, image/png)
2017-03-08 02:59 PST, Matt Baker
no flags Details
Patch (2.64 KB, patch)
2017-03-08 03:21 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-03-08 02:49:38 PST
Summary:
DetailsSections with options have broken layout. The following details panel sections are affected:

- Computed Styles (show all label)
- Pause Reason (goto arrow)
- Watch Expressions (toolbar)
- Visual Styles sidebar (?)

And soon:
- XHR Breakpoints (add button)

Regressed in http://trac.webkit.org/changeset/212998.
Comment 1 Matt Baker 2017-03-08 02:58:48 PST
Created attachment 303804 [details]
[Image] Watch Expressions section
Comment 2 Matt Baker 2017-03-08 02:59:22 PST
Created attachment 303805 [details]
[Image] Pause Reason section
Comment 3 Matt Baker 2017-03-08 03:00:13 PST
Computed Styles section wasn't affected after all, and works as expected.
Comment 4 Matt Baker 2017-03-08 03:21:05 PST
Created attachment 303807 [details]
Patch
Comment 5 BJ Burg 2017-03-08 16:57:32 PST
Comment on attachment 303807 [details]
Patch

rs=me, oops!
Comment 6 WebKit Commit Bot 2017-03-08 17:24:44 PST
Comment on attachment 303807 [details]
Patch

Clearing flags on attachment: 303807

Committed r213610: <http://trac.webkit.org/changeset/213610>
Comment 7 WebKit Commit Bot 2017-03-08 17:24:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-03-23 09:36:50 PDT
<rdar://problem/31221132>