Bug 169345 – Loading in-body stylesheets should not block rendering of elements before them

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Antti Koivisto]

Enable incremental rendering for in-body stylesheets.

[Antti Koivisto]

Created attachment 303791 [details]
patch

[Build Bot]

Comment on attachment 303791 [details]
patch

Attachment 303791 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3264505

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
svg/repaint/repaint-webkit-svg-shadow-container.html

[Build Bot]

Created attachment 303800 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303791 [details]
patch

Attachment 303791 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3264528

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
svg/repaint/repaint-webkit-svg-shadow-container.html

[Build Bot]

Created attachment 303801 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303791 [details]
patch

Attachment 303791 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3264536

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
svg/repaint/repaint-webkit-svg-shadow-container.html

[Build Bot]

Created attachment 303802 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 303791 [details]
patch

Attachment 303791 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3264568

New failing tests:
svg/as-image/img-zoom-svg-stylesheet.html
svg/repaint/repaint-webkit-svg-shadow-container.html

[Build Bot]

Created attachment 303803 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antti Koivisto]

Created attachment 303811 [details]
wip

[Antti Koivisto]

Created attachment 303812 [details]
wip

[Simon Fraser (smfr)]

Comment on attachment 303812 [details]
wip

View in context: https://bugs.webkit.org/attachment.cgi?id=303812&action=review

> Source/WebCore/dom/Document.cpp:1251
> +    fprintf(stderr, "Document::setVisualUpdatesAllowed %d\n", visualUpdatesAllowed);

You should add LOG(Style, ...) for logging like this that you find useful.

> Source/WebCore/dom/Document.cpp:1824
> +        if (m_renderView->needsLayout())
> +            frameView.scheduleRelayout();

How does needsLayout() become true without a layout already having been scheduled? This seems odd.

> Source/WebCore/rendering/RenderBlock.cpp:1536
> +        fprintf(stderr, "RenderBlock::paint isNotFinal\n");

LOG(Style, ...)?

> Source/WebCore/rendering/RenderLayer.cpp:3945
> +        fprintf(stderr, "shouldSuppressPaintingLayer\n");

Log(Style, ...)?

> Source/WebCore/style/StyleTreeResolver.cpp:171
> +        fprintf(stderr, "m_didSeePendingStylesheet not styling\n");

LOG

> Source/WebCore/style/StyleTreeResolver.cpp:184
> +        fprintf(stderr, "m_didSeePendingStylesheet marking non-final\n");

LOG

[Antti Koivisto]

*** This bug has been marked as a duplicate of bug 149157 ***

[Antti Koivisto]

> How does needsLayout() become true without a layout already having been
> scheduled? This seems odd.

We currently fail to schedule layout for a completely new render tree. Some random action later usually schedules it (or parser reaching the end of the document). Updates work as expected.

Moved this to the older bug.

[Ryan Haddad]

Reverted r213633 for reason:

This change caused LayoutTest imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html to become a flaky failure.

Committed r213701: <http://trac.webkit.org/changeset/213701>

[Ryan Haddad]

Duping back to older bug.

*** This bug has been marked as a duplicate of bug 149157 ***