Bug 169342 - WebKit should not export dyld install name hints on watchOS and tvOS
Summary: WebKit should not export dyld install name hints on watchOS and tvOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-07 22:18 PST by Alexey Proskuryakov
Modified: 2017-08-17 07:21 PDT (History)
5 users (show)

See Also:

Attachments
proposed fix (1.20 KB, patch)
2017-03-07 22:21 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-03-07 22:18:56 PST 
They are iOS only. Sadly, our PLATFORM macros are incorrect (we define IOS for these platforms too).
Comment 1 Alexey Proskuryakov 2017-03-07 22:21:09 PST 
Created attachment 303784 [details]
proposed fix
Comment 2 mitz 2017-03-07 23:03:53 PST 
Comment on attachment 303784 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=303784&action=review

> Source/WebKit2/Shared/API/Cocoa/WebKit.m:28
> +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

I think this is a case where we may gain an extra bit of robustness by checking for PLATFORM(IOS) && TARGET_OS_IOS instead (even if the latter is not available as a WTF macro). But this is fine too.
Comment 3 WebKit Commit Bot 2017-03-07 23:52:16 PST 
Comment on attachment 303784 [details]
proposed fix

Clearing flags on attachment: 303784

Committed r213569: <http://trac.webkit.org/changeset/213569>
Comment 4 WebKit Commit Bot 2017-03-07 23:52:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 mitz 2017-08-17 07:21:03 PDT 
rdar://problem/20163340