Bug 169314 - Some platforms won't be able to create a GPUDevice
Summary: Some platforms won't be able to create a GPUDevice
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2017-03-07 15:21 PST by Dean Jackson
Modified: 2017-03-07 16:12 PST (History)
9 users (show)

See Also:

Patch (12.04 KB, patch)
2017-03-07 15:56 PST, Dean Jackson
jonlee: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-03-07 15:21:36 PST
Not all hardware (or OS versions) support Metal.
Comment 1 Dean Jackson 2017-03-07 15:51:35 PST
Comment 2 Dean Jackson 2017-03-07 15:56:08 PST
Created attachment 303738 [details]
Comment 3 Jon Lee 2017-03-07 16:02:07 PST
Comment on attachment 303738 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=303738&action=review

> Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:44
> +    if (device) {

Reverse the conditional and early return.
Comment 4 Dean Jackson 2017-03-07 16:12:15 PST
Committed r213549: <http://trac.webkit.org/changeset/213549>