Currently, EWS sends 'ios' as the port name to run-webkit-tests. A work-around has been implemented in factory.py so that this value maps to 'ios-device.' EWS should be changed to pass in 'ios-device' and the workaround removed.
<rdar://problem/30953024>
Created attachment 303959 [details] Patch
Created attachment 305025 [details] Patch
Comment on attachment 305025 [details] Patch Attachment 305025 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3381462 New failing tests: fast/media/mq-prefers-reduced-motion.html
Created attachment 305087 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
@Jonathan: What's the status of this? It seemed the test failure was unrelated.
Created attachment 334745 [details] Patch
(In reply to Frédéric Wang (:fredw) from comment #6) > @Jonathan: What's the status of this? It seemed the test failure was > unrelated. I forgot about it. Sending it back through EWS to make sure the patch isn't stale.
Created attachment 334819 [details] Patch
The code change looks fine, but I don’t understand why the title of this bug talks about "should send the correct port". Isn’t this bug just a cleanup, with no change in behavior?
(In reply to Darin Adler from comment #10) > The code change looks fine, but I don’t understand why the title of this bug > talks about "should send the correct port". Isn’t this bug just a cleanup, > with no change in behavior? Yes, this is bug is just cleanup. Previously, we used the string 'ios' to indicate the iOSPort (used for managing building and testing of iOS devices, as opposed to iOS simulated devices). I change this so that the string 'ios-device' maps to the iOSPort. This mapping was left in because some of our EWS code still used the string 'ios' instead of 'ios-device'
So lets set the title on this bug accordingly.
Comment on attachment 334819 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
Created attachment 443008 [details] Patch
Committed r285131 (243770@main): <https://commits.webkit.org/243770@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443008 [details].