Bug 169276 – Align XMLHttpRequest's overrideMimeType() with the standard

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anne van Kesteren]

Tests: https://github.com/w3c/web-platform-tests/pull/4955 and https://github.com/w3c/web-platform-tests/pull/4993.

[Anne van Kesteren]

More changes: https://github.com/whatwg/xhr/pull/174 and https://github.com/w3c/web-platform-tests/pull/8449.

[Rob Buis]

Created attachment 350188 [details]
Patch

[Rob Buis]

Created attachment 350198 [details]
Patch

[EWS Watchlist]

Comment on attachment 350198 [details]
Patch

Attachment 350198 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9281363

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm

[EWS Watchlist]

Created attachment 350199 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350198 [details]
Patch

Attachment 350198 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9281440

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm

[EWS Watchlist]

Created attachment 350201 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 350198 [details]
Patch

Attachment 350198 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9281389

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm

[EWS Watchlist]

Created attachment 350205 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 350198 [details]
Patch

Attachment 350198 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9281473

New failing tests:
imported/w3c/web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm

[EWS Watchlist]

Created attachment 350210 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 350251 [details]
Patch

[Rob Buis]

Comment on attachment 350251 [details]
Patch

PTAL. Note that this has some overlap with https://bugs.webkit.org/show_bug.cgi?id=180526. Not sure if there is a better way of dealing with this.

Finally, forgot to say this matches Firefox and Chrome.

[Rob Buis]

Created attachment 350741 [details]
Patch

[Chris Dumez]

Comment on attachment 350741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350741&action=review

r=me

> Source/WebCore/xml/XMLHttpRequest.cpp:784
> +    m_mimeTypeOverride = "application/octet-stream";

"application/octet-stream"_s is slightly more efficient I believe.

[Rob Buis]

Manually landed as r236663.

[Chris Dumez]

(In reply to Rob Buis from comment #16)
> Manually landed as r236663.

Commit message is wrong:
https://trac.webkit.org/changeset/236663/webkit

Please use commit queue as much as possible.

[Radar WebKit Bug Importer]

<rdar://problem/44910346>

[Rob Buis]

(In reply to Chris Dumez from comment #17)
> (In reply to Rob Buis from comment #16)
> > Manually landed as r236663.
> 
> Commit message is wrong:
> https://trac.webkit.org/changeset/236663/webkit
> 
> Please use commit queue as much as possible.

Oops, sorry! I am a bit rusty but I am sure I'll get the hang of it (again) soon.

[Anne van Kesteren]

Rob, did you see https://github.com/whatwg/xhr/pull/218? We ended up reverting part of this and it seems I forgot to notify this bug about those plans. I'm sorry about that and hope it's not too much of a hassle to get that change in if it isn't already.

[Rob Buis]

Hi Anne, I think that is something we never implemented, i.e. once we set internal overrideMimeType we do not reset it at all. My change was about making overrideMimeType method only set overrideMimeType for valid mime parameter, and fallback to application/octet-stream otherwise.

[Anne van Kesteren]

Great!