Bug 169262 - [WebCrypto] Replace const std::unique_ptr<CryptoAlgorithmParameters>&& with const CryptoAlgorithmParameters& for CryptoAlgorithm::importKey
Summary: [WebCrypto] Replace const std::unique_ptr<CryptoAlgorithmParameters>&& with c...
Status: RESOLVED DUPLICATE of bug 187501
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-06 21:43 PST by Jiewen Tan
Modified: 2018-07-13 15:54 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2017-03-06 21:43:50 PST 
Current method CryptoAlgorithm::importKey is defined as follow:
void importKey(SubtleCrypto::KeyFormat, KeyData&&, const std::unique_ptr<CryptoAlgorithmParameters>&&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&);

A const rvalue reference makes no sense here. Therefore, I propose it should be rewritten as:
void importKey(SubtleCrypto::KeyFormat, KeyData&&, const CryptoAlgorithmParameters&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&);
Comment 1 Jiewen Tan 2018-07-13 15:54:36 PDT 

*** This bug has been marked as a duplicate of bug 187501 ***