RESOLVED DUPLICATE of bug 187501 169262
[WebCrypto] Replace const std::unique_ptr<CryptoAlgorithmParameters>&& with const CryptoAlgorithmParameters& for CryptoAlgorithm::importKey 
https://bugs.webkit.org/show_bug.cgi?id=169262
Summary [WebCrypto] Replace const std::unique_ptr<CryptoAlgorithmParameters>&& with c...
Jiewen Tan
Reported 2017-03-06 21:43:50 PST
Current method CryptoAlgorithm::importKey is defined as follow: void importKey(SubtleCrypto::KeyFormat, KeyData&&, const std::unique_ptr<CryptoAlgorithmParameters>&&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&); A const rvalue reference makes no sense here. Therefore, I propose it should be rewritten as: void importKey(SubtleCrypto::KeyFormat, KeyData&&, const CryptoAlgorithmParameters&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&);
Attachments
Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2018-07-13 15:54:36 PDT
*** This bug has been marked as a duplicate of bug 187501 ***
Note You need to log in before you can comment on or make changes to this bug.