Bug 169243 – Fix -Wattributes warning spam

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Michael Catanzaro]

-Wattributes warning spam caused by r213198:

../../Source/WebKit2/UIProcess/API/C/WKPageGroup.h:55:102: warning: ‘unavailable’ attribute directive ignored [-Wattributes]
 WK_EXPORT WKStringRef WKPageGroupCopyIdentifier(WKPageGroupRef pageGroup) __attribute__((unavailable));
                                                                                                      ^
../../Source/WebKit2/UIProcess/API/C/WKPageGroup.h:56:143: warning: ‘unavailable’ attribute directive ignored [-Wattributes]
 WK_EXPORT void WKPageGroupAddUserContentFilter(WKPageGroupRef pageGroup, WKUserContentFilterRef userContentFilter) __attribute__((unavailable));
                                                                                                                                               ^
../../Source/WebKit2/UIProcess/API/C/WKPageGroup.h:57:139: warning: ‘unavailable’ attribute directive ignored [-Wattributes]
 WK_EXPORT void WKPageGroupRemoveUserContentFilter(WKPageGroupRef pageGroup, WKStringRef userContentFilterName) __attribute__((unavailable));

It prints hundreds of times, since it's in a header file.

[Michael Catanzaro]

Created attachment 303600 [details]
Patch

Comment on attachment 303600 [details]
Patch

Don’t import wtf headers from WebKit2 framework headers. Instead, you can define WK_UNAVAILABLE in WKDeclarationSpecifiers.h.

[Michael Catanzaro]

(In reply to comment #2)
> Comment on attachment 303600 [details]
> Patch
> 
> Don’t import wtf headers from WebKit2 framework headers.

Umm yeah, that was dumb, oops.

[Alexey Proskuryakov]

This failure is surprising, given that NS_UNAVAILAbLE is defined in macOS like this:

/*
 * only certain compilers support __attribute__((unavailable))
 */
#if defined(__GNUC__) && ((__GNUC__ >= 4) || ((__GNUC__ == 3) && (__GNUC_MINOR__ >= 1)))
    #define UNAVAILABLE_ATTRIBUTE __attribute__((unavailable))
#else
    #define UNAVAILABLE_ATTRIBUTE
#endif

#if !defined(NS_UNAVAILABLE)
#define NS_UNAVAILABLE UNAVAILABLE_ATTRIBUTE
#endif

[Michael Catanzaro]

Weird. I have absolutely no clue; maybe it used to exist but was removed (very unlikely), maybe Apple has its own fork of GCC where it added that attribute (seems unlikely too), maybe you don't care about GCC and the check is really just there for Clang (also seems unlikely)... I don't know! It's not documented anywhere and it definitely does not work.

[Michael Catanzaro]

Created attachment 303703 [details]
Patch

[Michael Catanzaro]

Let's see if EWS likes this.

Note: __has_extension is guaranteed to be defined where I removed the check for it; that's a drive-by cleanup.

[Michael Catanzaro]

Comment on attachment 303703 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 303703 [details]
Patch

Clearing flags on attachment: 303703

Committed r213620: <http://trac.webkit.org/changeset/213620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.