WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
169241
[Mac][WK2] Support new CoreMedia routing features
https://bugs.webkit.org/show_bug.cgi?id=169241
Summary
[Mac][WK2] Support new CoreMedia routing features
Brent Fulgham
Reported
2017-03-06 17:37:36 PST
Update the WebProcess sandbox (on macOS) to support two new XPC connection points.
Attachments
Patch
(1.60 KB, patch)
2017-03-06 17:39 PST
,
Brent Fulgham
ap
: review+
ap
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2017-03-06 17:38:38 PST
<
rdar://problem/30077969
>
Brent Fulgham
Comment 2
2017-03-06 17:39:23 PST
Created
attachment 303592
[details]
Patch
Alexey Proskuryakov
Comment 3
2017-03-06 18:32:29 PST
Comment on
attachment 303592
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=303592&action=review
> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:370 > + ; Note: "com.apple.coremedia.endpointpicker.xpc" can be removed when <
rdar://problem/30081582
> is resolved.
Please remove "Note: ", as all comments are notes.
> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200
Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300".
Brent Fulgham
Comment 4
2017-03-06 19:04:50 PST
Comment on
attachment 303592
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=303592&action=review
>> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372 >> +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200 > > Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300".
I am told by our build team that this value is only ever set to a full release version, though there's no specific reason why this must be true. I'm happy to change to 101300.
Brent Fulgham
Comment 5
2017-03-06 19:09:46 PST
Committed
r213490
: <
http://trac.webkit.org/changeset/213490
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug