Bug 169241 - [Mac][WK2] Support new CoreMedia routing features
Summary: [Mac][WK2] Support new CoreMedia routing features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-03-06 17:37 PST by Brent Fulgham
Modified: 2017-03-06 19:09 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2017-03-06 17:39 PST, Brent Fulgham 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-03-06 17:37:36 PST 
Update the WebProcess sandbox (on macOS) to support two new XPC connection points.
Comment 1 Brent Fulgham 2017-03-06 17:38:38 PST 
<rdar://problem/30077969>
Comment 2 Brent Fulgham 2017-03-06 17:39:23 PST 
Created attachment 303592 [details]
Patch
Comment 3 Alexey Proskuryakov 2017-03-06 18:32:29 PST 
Comment on attachment 303592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303592&action=review

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:370
> +    ; Note: "com.apple.coremedia.endpointpicker.xpc" can be removed when <rdar://problem/30081582> is resolved.

Please remove "Note: ", as all comments are notes.

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200

Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300".
Comment 4 Brent Fulgham 2017-03-06 19:04:50 PST 
Comment on attachment 303592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303592&action=review

>> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:372
>> +#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101200
> 
> Does __MAC_OS_X_VERSION_MIN_REQUIRED ever change for point update SDKs? Maybe the check should be ">= 101300".

I am told by our build team that this value is only ever set to a full release version, though there's no specific reason why this must be true. I'm happy to change to 101300.
Comment 5 Brent Fulgham 2017-03-06 19:09:46 PST 
Committed r213490: <http://trac.webkit.org/changeset/213490>