Bug 169234 - clean up invalid domains in contributors.json
Summary: clean up invalid domains in contributors.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-06 16:04 PST by Lucas Forschler
Modified: 2018-01-11 06:57 PST (History)
4 users (show)

See Also:

Attachments
remove torchmobile.com.cn email accounts. (2.28 KB, patch)
2017-03-06 16:06 PST, Lucas Forschler 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-03-06 16:04:46 PST 
I've been informed that torchmobile.com.cn is an unregistered domain. These email addresses will bounce. Clean them up.
Comment 1 Lucas Forschler 2017-03-06 16:06:27 PST 
Created attachment 303578 [details]
remove torchmobile.com.cn email accounts.
Comment 2 WebKit Commit Bot 2017-03-06 16:08:41 PST 
Attachment 303578 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Lucas Forschler 2017-03-06 16:13:13 PST 
Looks like I'll need to land this manually. Please do not CQ+ it.
Comment 4 Lucas Forschler 2017-03-06 16:20:47 PST 
Committed revision 213479.
Comment 5 Konstantin Tokarev 2018-01-11 06:57:09 PST 
I thought one of purposes of contributors.json was identifying person from e-mail adress of the commit. In our history there are 187 commits with commiter email e-mail matching torchmobile.com.cn