So as to match headers exactly with the binary and make TAPI happy.
Created attachment 303567 [details] Proposed patch
Comment on attachment 303567 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=303567&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKLinkIconParameters.h:38 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I don't think that this one is accurate. I don't see _WKLinkIconParameters in any shipping WebKit version.
Created attachment 303589 [details] Updated patch
Comment on attachment 303589 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review > Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 > +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) I think this file should be in UIProcess/API/Cocoa?
Comment on attachment 303589 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=303589&action=review >> Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.h:33 >> +WK_CLASS_AVAILABLE(macosx(10.10), ios(8.0)) > > I think this file should be in UIProcess/API/Cocoa? Also, not available on Mac
Let's do that in a separate patch. This patch focus on fixing errors from TAPI.
> Also, not available on Mac That part can be fixed in this patch - I think that "macosx(NA)" would be right.
Yeah. I believe removing macos() and just keeping WK_CLASS_AVAILABLE(ios(8.0)) should be fine. Similar to: https://trac.webkit.org/changeset/205559/trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreviewElementInfo.h
Created attachment 303604 [details] Updated patch patch for landing.
Comment on attachment 303604 [details] Updated patch Clearing flags on attachment: 303604 Committed r213495: <http://trac.webkit.org/changeset/213495>
All reviewed patches have been landed. Closing bug.