Bug 169223 - [Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective-C bundle SPI
Summary: [Cocoa] Expose API::InjectedBundle::EditorClient::didChange via the Objective...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-06 15:05 PST by mitz
Modified: 2017-03-06 21:15 PST (History)
1 user (show)

See Also:

Attachments
Add _webProcessPlugInBrowserContextControllerDidChange: (4.83 KB, patch)
2017-03-06 17:16 PST, mitz 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2017-03-06 15:05:44 PST 
A WebKit client requires a bundle notification when the contents change due to editing.
Comment 1 mitz 2017-03-06 17:16:11 PST 
Created attachment 303588 [details]
Add _webProcessPlugInBrowserContextControllerDidChange:
Comment 2 WebKit Commit Bot 2017-03-06 17:17:29 PST 
Attachment 303588 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:626:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2017-03-06 17:17:55 PST 
Comment on attachment 303588 [details]
Add _webProcessPlugInBrowserContextControllerDidChange:

View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58
> +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller;

I do not love this name.
Comment 4 mitz 2017-03-06 20:04:51 PST 
Comment on attachment 303588 [details]
Add _webProcessPlugInBrowserContextControllerDidChange:

View in context: https://bugs.webkit.org/attachment.cgi?id=303588&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:58
>> +- (void)_webProcessPlugInBrowserContextControllerDidChange:(WKWebProcessPlugInBrowserContextController *)controller;
> 
> I do not love this name.

We are going to append “ByEditing”.
Comment 5 mitz 2017-03-06 21:15:45 PST 
Committed <https://trac.webkit.org/r213498>.