Bug 169195 - Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content
Summary: Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
Depends on:
Blocks: 60731
  Show dependency treegraph
Reported: 2017-03-06 04:50 PST by Manuel Rego Casasnovas
Modified: 2017-03-13 04:44 PDT (History)
9 users (show)

See Also:

Patch (238.69 KB, patch)
2017-03-07 01:24 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (239.73 KB, patch)
2017-03-07 02:13 PST, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch for landing (239.54 KB, patch)
2017-03-13 03:08 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2017-03-06 04:50:32 PST
It'd be really nice to unprefix these properties for CSS Grid Layout.

This would be similar to what we're already doing for "fit-content" which is unprefix for Grid Layout, but prefixed if you use it in "width" or "height" properties.
Comment 1 Manuel Rego Casasnovas 2017-03-07 01:11:20 PST
After checking the status of things I believe we should unprefix min-content, max-content and fit-content for all the elements and not only Grid Layout.

As we're now shipping Grid Layout, having to mix prefixes with no prefixes in declarations is really confusing:
  grid-tempalte-columns: -webkit-min-content fit-content(500px) -webkit-max-content;

So my proposal would be to follow the path started by Blink and unprefix those properties, and wait until for the CSS WG resolution regarding -webkit-fill-available. That would move us to the same status than Blink.
See https://bugs.chromium.org/p/chromium/issues/detail?id=245157 for more information.

There were a previous discussion on webkit-dev about this, and the only comment was in favor of doing it:

Also there's a FIXME on the new parser about this:
// FIXME-NEWPARSER: Drop the prefix on min-content, max-content and fit-content.

Note that we should keep support for the prefixed properties, as people have been using them for a long time. They could eventually be deprecated and removed in the future.
Comment 2 Manuel Rego Casasnovas 2017-03-07 01:24:06 PST
Created attachment 303637 [details]
Comment 3 Manuel Rego Casasnovas 2017-03-07 02:13:38 PST
Created attachment 303638 [details]

Update results for css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing.html that was already using the unprefixed version.
Comment 4 Simon Fraser (smfr) 2017-03-07 08:31:21 PST
Please also update CSSProperties.json.
Comment 5 Manuel Rego Casasnovas 2017-03-07 12:14:14 PST
(In reply to comment #4)
> Please also update CSSProperties.json.

These are values for width and height properties (also min|max-width|height),
so not new properties but new keywords.
I don't find the old prefixed versions on CSSProperties.json,
what should I add there?
Comment 6 Sergio Villar Senin 2017-03-13 02:30:00 PDT
Comment on attachment 303638 [details]

Check the error reported by the bindings EWS
Comment 7 Manuel Rego Casasnovas 2017-03-13 03:08:47 PDT
Created attachment 304248 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2017-03-13 04:44:50 PDT
Comment on attachment 304248 [details]
Patch for landing

Clearing flags on attachment: 304248

Committed r213831: <http://trac.webkit.org/changeset/213831>
Comment 9 WebKit Commit Bot 2017-03-13 04:44:55 PDT
All reviewed patches have been landed.  Closing bug.