Bug 169195 – Unprefix -webkit-min-content, -webkit-max-content and -webkit-fit-content

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Manuel Rego Casasnovas]

It'd be really nice to unprefix these properties for CSS Grid Layout.

This would be similar to what we're already doing for "fit-content" which is unprefix for Grid Layout, but prefixed if you use it in "width" or "height" properties.

[Manuel Rego Casasnovas]

After checking the status of things I believe we should unprefix min-content, max-content and fit-content for all the elements and not only Grid Layout.

As we're now shipping Grid Layout, having to mix prefixes with no prefixes in declarations is really confusing:
  grid-tempalte-columns: -webkit-min-content fit-content(500px) -webkit-max-content;

So my proposal would be to follow the path started by Blink and unprefix those properties, and wait until for the CSS WG resolution regarding -webkit-fill-available. That would move us to the same status than Blink.
See https://bugs.chromium.org/p/chromium/issues/detail?id=245157 for more information.

There were a previous discussion on webkit-dev about this, and the only comment was in favor of doing it:
https://lists.webkit.org/pipermail/webkit-dev/2015-August/027604.html

Also there's a FIXME on the new parser about this:
// FIXME-NEWPARSER: Drop the prefix on min-content, max-content and fit-content.

Note that we should keep support for the prefixed properties, as people have been using them for a long time. They could eventually be deprecated and removed in the future.

[Manuel Rego Casasnovas]

Created attachment 303637 [details]
Patch

[Manuel Rego Casasnovas]

Created attachment 303638 [details]
Patch

Update results for css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing.html that was already using the unprefixed version.

[Simon Fraser (smfr)]

Please also update CSSProperties.json.

[Manuel Rego Casasnovas]

(In reply to comment #4)
> Please also update CSSProperties.json.

These are values for width and height properties (also min|max-width|height),
so not new properties but new keywords.
I don't find the old prefixed versions on CSSProperties.json,
what should I add there?

[Sergio Villar Senin]

Comment on attachment 303638 [details]
Patch

Check the error reported by the bindings EWS

[Manuel Rego Casasnovas]

Created attachment 304248 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 304248 [details]
Patch for landing

Clearing flags on attachment: 304248

Committed r213831: <http://trac.webkit.org/changeset/213831>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.